[
https://issues.apache.org/jira/browse/HDFS-12522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340162#comment-16340162
]
Anu Engineer commented on HDFS-12522:
-------------------------------------
[~xyao] and [~nandakumar131] Thanks for review comments, I have uploaded v3 of
the patch.
Here are the changes in the v3.
bq. ContainerStateMap.java Line:86 Extra “;”
Fixed.
bq. ContainerStateMap#updateState : As the name suggests, we should use it only
for updating the state of the container.
I wish we could get something as clean as this. Many times a state change
happens due to some variable change its state. So we have to update both the
state and value change in an atomic fashion.
bq. line numbers were 427 - 429
Thanks for letting me know.
bq. SCMException.java: NIT: Line 117 unncessary change.
Good catch, fixed.
bq. BlockManagerImpl.java Line 270: the udpate of allocatedbytes looks good to
me. I notice that we have a TODO in 421 to reclaim the deleted block space from
container. Please ensure we have a open JIRA on this to fix this.
Filed HDFS-13067.
bq. ContainerMapping.java Line 408, # of parameter does not match the # of {}
in the LOG.error statement.
Thank you for catching that. I fixed both the log lines that were faulty.
> Ozone: Remove the Priority Queues used in the Container State Manager
> ---------------------------------------------------------------------
>
> Key: HDFS-12522
> URL: https://issues.apache.org/jira/browse/HDFS-12522
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Priority: Major
> Attachments: HDFS-12522-HDFS-7240.001.patch,
> HDFS-12522-HDFS-7240.002.patch, HDFS-12522-HDFS-7240.003.patch
>
>
> During code review of HDFS-12387, it was suggested that we remove the
> priority queues that was used in ContainerStateManager. This JIRA tracks that
> issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
