[ https://issues.apache.org/jira/browse/HDFS-1955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050940#comment-13050940 ]
Hadoop QA commented on HDFS-1955: --------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12482900/hdfs-1955_1.patch against trunk revision 1136741. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestDFSRollback +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/791//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/791//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/791//console This message is automatically generated. > HDFS-1826 made FSImage.doUpgrade() too fault-tolerant > ----------------------------------------------------- > > Key: HDFS-1955 > URL: https://issues.apache.org/jira/browse/HDFS-1955 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node > Affects Versions: 0.22.0, 0.23.0 > Reporter: Matt Foley > Assignee: Matt Foley > Attachments: hdfs-1955_1.patch > > > Prior to HDFS-1826, doUpgrade() would fail if any of the storage directories > failed to successfully write the new fsimage or edits files. > Now it appears to "succeed" even if some or all of the individual directories > fail. > There is some discussion about whether doUpgrade() should have some fault > tolerance, but for now make it fail on any single storage directory failure, > as before. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira