[
https://issues.apache.org/jira/browse/HDFS-12997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16345716#comment-16345716
]
Xiaoyu Yao commented on HDFS-12997:
-----------------------------------
Thanks [~ajayydv] for the update. The patch looks good to me. Two more minor
issues, +1 after that being fixed.
BlockPoolSliceStorage.java
LINE 169-170: "formatted for {}" is redundant. We can remove it and the 2nd
"nsInfo.getBlockPoolID()"
NNStorage.java
Line 866-867: can we wrap these two calls inside {color}if
(LOG.isDebugEnabled()) to minimize performance impact of logging?
Line 882-883: Same as above
> Move logging to slf4j in BlockPoolSliceStorage and Storage
> -----------------------------------------------------------
>
> Key: HDFS-12997
> URL: https://issues.apache.org/jira/browse/HDFS-12997
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Attachments: HDFS-12997.001.patch, HDFS-12997.002.patch,
> HDFS-12997.003.patch, HDFS-12997.004.patch, HDFS-12997.005.patch,
> HDFS-12997.006.patch
>
>
> Move logging to slf4j in BlockPoolSliceStorage and Storage classes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
