[
https://issues.apache.org/jira/browse/HDFS-13095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348072#comment-16348072
]
Xiao Chen commented on HDFS-13095:
----------------------------------
I think it's also arguable whether snapshots should be supported for sps.
What's the use case where we need to support snapshot on sps?
The major consideration for re-encryption is snapshots are supposed to be
immutable (at least not to further complicate the semantic), and simplicity of
code / test / support.
> Improve slice tree traversal implementation
> -------------------------------------------
>
> Key: HDFS-13095
> URL: https://issues.apache.org/jira/browse/HDFS-13095
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Rakesh R
> Assignee: Rakesh R
> Priority: Major
>
> This task is to refine the existing slice tree traversal logic in
> [ReencryptionHandler|https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ReencryptionHandler.java#L74]
> class.
> Please refer Daryn's review comments
> {quote}*FSTreeTraverser*
> I need to study this more but I have grave concerns this will work correctly
> in a mutating namesystem. Ex. renames and deletes esp. in combination with
> snapshots. Looks like there's a chance it will go off in the weeds when
> backtracking out of a renamed directory.
> traverseDir may NPE if it's traversing a tree in a snapshot and one of the
> ancestors is deleted.
> Not sure why it's bothering to re-check permissions during the crawl. The
> storage policy is inherited by the entire tree, regardless of whether the
> sub-contents are accessible. The effect of this patch is the storage policy
> is enforced for all readable files, non-readable violate the new storage
> policy, new non-readable will conform to the new storage policy. Very
> convoluted. Since new files will conform, should just process the entire
> tree.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
