[
https://issues.apache.org/jira/browse/HDFS-13097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348346#comment-16348346
]
Rakesh R commented on HDFS-13097:
---------------------------------
Thanks [~surendrasingh] for taking care this changes. Adding few comments,
# Please move {{DFSUtil#getSPSWorkMultiplier}} to StoragePolicySatisfier.java
# How abt changing MOVERTHREADS value in like,
{code}
conf.getInt(DFSConfigKeys.DFS_MOVER_MOVERTHREADS_KEY, 10);
{code}
# synchronized also to be removed as we are changing to BlockingQ. Also,
{{blockMovingInfos.add(storageMovementBlocks.poll());}} to be changed to =>
{{storageMovementBlocks.drainTo(blockMovingInfos);}}
# As we are creating SPSManager class, it is good to remove the {{SPS}} keyword
from the variables and methods in this class. Adding few example cases like,
{code}
Methods:
------------
stopSPS() ==> stop()
isSPSEnabled ==> isEnabled()
startSPS ==> start()
enableInternalSPS ==> enableInternalSatisfier
enableExternalSPS ==> enableExternalSatisfier
updateSPSMode ==> updateMode
disableSPS ==> disable
stopSPSGracefully ==> stopGracefully
isStoragePolicySatisfierRunning ==> isSatisfierRunning
getSPSService ==> getService
getNextSPSPathId ==> getNextPathId
verifyOutstandingSPSPathQLimit ==> verifyOutstandingPathQLimit
removeSPSPathId ==> removePathId
removeAllSPSPathIds ==> removeAllPathIds
addSPSPathId ==> addPathId
isSPSEnabled ==> isEnabled
getSPSMode ==> getMode
Variables:
-------------
spsMode ==> mode
spsPaths ==> paths
spsOutstandingPathsLimit ==> outstandingPathsLimit
{code}
> [SPS]: Fix the branch review comments(Part1)
> --------------------------------------------
>
> Key: HDFS-13097
> URL: https://issues.apache.org/jira/browse/HDFS-13097
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: HDFS-10285
> Reporter: Surendra Singh Lilhore
> Assignee: Surendra Singh Lilhore
> Priority: Major
> Attachments: HDFS-13097-HDFS-10285.01.patch
>
>
> Fix the branch review comment.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
