[ https://issues.apache.org/jira/browse/HDFS-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355112#comment-16355112 ]
Yiqun Lin commented on HDFS-13099: ---------------------------------- Looks like the change for impl class broken the unit tests. {noformat} 2018-02-07 04:43:43,016 [main] ERROR impl.StateStoreZooKeeperImpl (StateStoreZooKeeperImpl.java:initDriver(85)) - Cannot initialize the ZK connection java.io.IOException: hadoop.zk.address is not configured. at org.apache.hadoop.util.curator.ZKCuratorManager.start(ZKCuratorManager.java:128) at org.apache.hadoop.util.curator.ZKCuratorManager.start(ZKCuratorManager.java:115) at org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreZooKeeperImpl.initDriver(StateStoreZooKeeperImpl.java:83) at org.apache.hadoop.hdfs.server.federation.store.driver.StateStoreDriver.init(StateStoreDriver.java:74) at org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreSerializableImpl.init(StateStoreSerializableImpl.java:47) {noformat} This seems a incompatible change. Attach the update patch. > RBF: Use the ZooKeeper as the default State Store > ------------------------------------------------- > > Key: HDFS-13099 > URL: https://issues.apache.org/jira/browse/HDFS-13099 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: documentation > Affects Versions: 3.0.0 > Reporter: Yiqun Lin > Assignee: Yiqun Lin > Priority: Minor > Attachments: HDFS-13099.001.patch, HDFS-13099.002.patch, > HDFS-13099.003.patch, HDFS-13099.004.patch > > > Currently the State Store Driver relevant settings only written in its > implement classes. > {noformat} > public class StateStoreZooKeeperImpl extends StateStoreSerializableImpl { > ... > /** Configuration keys. */ > public static final String FEDERATION_STORE_ZK_DRIVER_PREFIX = > DFSConfigKeys.FEDERATION_STORE_PREFIX + "driver.zk."; > public static final String FEDERATION_STORE_ZK_PARENT_PATH = > FEDERATION_STORE_ZK_DRIVER_PREFIX + "parent-path"; > public static final String FEDERATION_STORE_ZK_PARENT_PATH_DEFAULT = > "/hdfs-federation"; > .. > {noformat} > Actually, they should be moved into class {{DFSConfigKeys}} and documented in > file {{hdfs-default.xml}}. This will help more users know these settings and > know how to use. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org