[ https://issues.apache.org/jira/browse/HDFS-13110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355685#comment-16355685 ]
Rakesh R commented on HDFS-13110: --------------------------------- Attached new patch fixing test case failures and checkstyle warnings, > [SPS]: Reduce the number of APIs in NamenodeProtocol used by external > satisfier > ------------------------------------------------------------------------------- > > Key: HDFS-13110 > URL: https://issues.apache.org/jira/browse/HDFS-13110 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Rakesh R > Assignee: Rakesh R > Priority: Major > Attachments: HDFS-13110-HDFS-10285-00.patch, > HDFS-13110-HDFS-10285-01.patch, HDFS-13110-HDFS-10285-02.patch > > > This task is to address the following [~daryn]'s comments. Please refer > HDFS-10285 to see more detailed discussion. > *Comment-10)* > {quote} > NamenodeProtocolTranslatorPB > Most of the api changes appear unnecessary. > IntraSPSNameNodeContext#getFileInfo swallows all IOEs, based on assumption > that any and all IOEs means FNF which probably isn’t the intention during rpc > exceptions. > {quote} > *Comment-13)* > {quote} > StoragePolicySatisfier > It appears to make back-to-back calls to hasLowRedundancyBlocks and > getFileInfo for every file. Haven’t fully groked the code, but if low > redundancy is not the common case, then it shouldn’t be called unless/until > needed. It looks like files that are under replicated are re-queued again? > {quote} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org