[ 
https://issues.apache.org/jira/browse/HDFS-13022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358209#comment-16358209
 ] 

Elek, Marton commented on HDFS-13022:
-------------------------------------

Thank you very much the review [~msingh].

 

1. they should be fixed now 
([commit1|https://github.com/elek/hadoop/commit/3a9031d60c21c687e79ee04e0f2bdd64c42c0e3b],
 
[commit2|https://github.com/elek/hadoop/commit/2c68fd70a7e69299cbd38858592defd435bc1862]
 )

2,3: Fixed: 
[commit1|https://github.com/elek/hadoop/commit/9a68d59080d419c0e5df99c96f61126c8609a5b3]

4. This is just a test file which won't be included in any release, so IMHO we 
shouldn't. I checked other json files, and there was no asf header + I got no 
RAT warning.

5. Good question, but fortunatelly we don't need to add anything. See my 
analysis bellow. There was one problematic dependenciy (system-rules). I 
[excluded|https://github.com/elek/hadoop/commit/bd8a27853e248e3dae976d2400748eda6c121b45]
 it from the pom.xml and created a 
[PR|https://github.com/kubernetes-client/java/pull/182] to use it with test 
scope in the future.

6. yep, I removed it.

About the licences:

These are the new jar files which are introduced:
{code:java}
[INFO] +- io.kubernetes:client-java:jar:1.0.0-beta1:compile
[INFO] |  +- io.kubernetes:client-java-api:jar:1.0.0-beta1:compile
[INFO] |  |  +- com.squareup.okhttp:logging-interceptor:jar:2.7.5:compile
[INFO] |  |  \- joda-time:joda-time:jar:2.9.9:compile
[INFO] |  +- io.kubernetes:client-java-proto:jar:1.0.0-beta1:compile
[INFO] |  +- org.yaml:snakeyaml:jar:1.16:compile
[INFO] |  \- com.squareup.okhttp:okhttp-ws:jar:2.7.5:compile
{code}
OkHttp, Joda time and snakeyaml are not new dependencies (included 
hadoop-azure-datalake, and hadoop-project)

And anyway: all of them are licenced under Apache licence without copyright 
notice:
 * Kubernetes Java client: Apache licence without notice: 
[https://github.com/kubernetes-client/java/blob/master/LICENSE]
 * Okhttp: Apache licence without copyright notice: 
[https://github.com/square/okhttp/blob/master/LICENSE.txt]
 * SnakeYaml: Apache licence without copyright notice: 
[https://bitbucket.org/asomov/snakeyaml/src/5d89bc78c3e9c6313f7111d596fe5b454d66d7fc/LICENSE.txt?at=default&fileviewer=file-view-default]
 * Joda-Time: [http://joda-time.sourceforge.net/license.html]

 

 

> Block Storage: Kubernetes dynamic persistent volume provisioner
> ---------------------------------------------------------------
>
>                 Key: HDFS-13022
>                 URL: https://issues.apache.org/jira/browse/HDFS-13022
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: HDFS-7240
>    Affects Versions: HDFS-7240
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>         Attachments: HDFS-13022-HDFS-7240.001.patch, 
> HDFS-13022-HDFS-7240.002.patch, HDFS-13022-HDFS-7240.003.patch, 
> HDFS-13022-HDFS-7240.004.patch
>
>
> {color:#FF0000}{color}
> With HDFS-13017 and HDFS-13018 the cblock/jscsi server could be used in a 
> kubernetes cluster as the backend for iscsi persistent volumes.
> Unfortunatelly we need to create all the required cblocks manually with 'hdfs 
> cblok -c user volume...' for all the Persistent Volumes.
>  
> But it could be handled with a simple optional component. An additional 
> service could listen on the kubernetes event stream. In case of new 
> PersistentVolumeClaim (where the storageClassName is cblock) the cblock 
> server could create cblock in advance AND create the persistent volume could 
> be created.
>  
> The code is very simple, and this additional component could be optional in 
> the cblock server.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to