[ https://issues.apache.org/jira/browse/HDFS-11600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359850#comment-16359850 ]
SammiChen commented on HDFS-11600: ---------------------------------- I uploaded a new patch based on Andrew's 002 patch. The idea is to separate {{TestDFSStripedOutputStreamWithFailure}} into {{TestDFSStripedOutputStreamWithFailureBase}} which carries common routines and variable defines, {{TestDFSStripedOutputStreamWithFailure}} which carries fixed parameter test cases, and {{TestDFSStripedOutputStreamWithFailureP}} which carries parameterized test case. In {{TestDFSStripedOutputStreamWithFailureP}}, I refine the current test case. Each time it will randomly choose 10 file length to run the test case. Given that the largest built-in EC policy currently support is RS-10-4-1MB, 10 rounds of same test case with random 1 data node failure seems enough. [~andrew.wang], would you take a look at the new patch at your convenient time? > Refactor TestDFSStripedOutputStreamWithFailure test classes > ----------------------------------------------------------- > > Key: HDFS-11600 > URL: https://issues.apache.org/jira/browse/HDFS-11600 > Project: Hadoop HDFS > Issue Type: Improvement > Components: test > Affects Versions: 3.0.0-alpha2 > Reporter: Andrew Wang > Priority: Minor > Attachments: HDFS-11600-1.patch, HDFS-11600.002.patch, > HDFS-11600.003.patch > > > TestDFSStripedOutputStreamWithFailure has a great number of subclasses. The > tests are parameterized based on the name of these subclasses. > Seems like we could parameterize these tests with JUnit and then not need all > these separate test classes. > Another note, the tests will randomly return instead of running the test. > Using {{Assume}} instead would make it more clear in the test output that > these tests were skipped. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org