[ 
https://issues.apache.org/jira/browse/HDFS-13119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364058#comment-16364058
 ] 

Yiqun Lin edited comment on HDFS-13119 at 2/14/18 1:51 PM:
-----------------------------------------------------------

Thanks for the review, [~elgoiri].
{quote}Otherwise, we could just do:
{noformat}
 if (isClusterUnAvailable(nsId) && retryCount > 0) {
 throw new IOException("No namenode available under nameservice " + nsId, ioe);
 }
{noformat}
Then, the default logic takes care of the first retry.
{quote}
Actually the default logic won't takes care of the first retry. Here we use the 
retry policy {{FailoverOnNetworkExceptionRetry}}, it will firstly jump into 
logic of {{RetryDecision.FAILOVER_AND_RETRY}} and throw {{StandbyException}}. 
In the failover rerty, the retry count is passing as 0 again.

 

Attach the new patch to fix some warnings.


was (Author: linyiqun):
Thanks for the review, [~elgoiri].
{quote}Otherwise, we could just do:
{noformat}
 if (isClusterUnAvailable(nsId) && retryCount > 0) {
 throw new IOException("No namenode available under nameservice " + nsId, ioe);
 }
{noformat}
Then, the default logic takes care of the first retry.
{quote}
Actually the default logic won't takes care of the first retry. Here we use the 
retry policy {{FailoverOnNetworkExceptionRetry}}, it will firstly jump into 
logic of {{RetryDecision.FAILOVER_AND_RETRY}} and throw {{StandbyException}}. 
In the failover rerty, the retry count is passing as 0 again.

> RBF: Manage unavailable clusters
> --------------------------------
>
>                 Key: HDFS-13119
>                 URL: https://issues.apache.org/jira/browse/HDFS-13119
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Íñigo Goiri
>            Assignee: Yiqun Lin
>            Priority: Major
>         Attachments: HDFS-13119.001.patch, HDFS-13119.002.patch, 
> HDFS-13119.003.patch
>
>
> When a federated cluster has one of the subcluster down, operations that run 
> in every subcluster ({{RouterRpcClient#invokeAll()}}) may take all the RPC 
> connections.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to