[
https://issues.apache.org/jira/browse/HDFS-13178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373417#comment-16373417
]
Anu Engineer commented on HDFS-13178:
-------------------------------------
I am +1 on this change (completely agree with renamining force to
skipDateCheck, see [~arpitagarwal]'s comment).
I have a minor suggestion: Not that it helps, but just to make myself feel
better, would you please add a warning that says something like :
{{"Skipping date check on this plan. This could mean we are executing an old
plan and may not be the right plan for this data node."}} or something to that
effect.
This might mean you will need the if check as in the original code or you can
add that warning inside {{submitPlan}} code too.
nit: datecheck ==> "date check" (ExecuteCommand.java:Line 52)
> Add a force option to DiskBalancer Execute command
> --------------------------------------------------
>
> Key: HDFS-13178
> URL: https://issues.apache.org/jira/browse/HDFS-13178
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: diskbalancer
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Attachments: HDFS-13178.00.patch
>
>
>
> Add a force option to DiskBalancer Execute command, which is used for skip
> date check and force execute the plan.
> This is one of the TODO for diskbalancer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
