[ https://issues.apache.org/jira/browse/HDFS-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052948#comment-13052948 ]
Eli Collins commented on HDFS-2088: ----------------------------------- Shouldn't archiveLogsOlderThan compare lastTxId < minImageTxId? The comment in archiveLogsOlderThan indicates minImageTxId is the earliest txid that must be retained after purging, but since archiveLogsOlderThan compares less than or equals to minImageTxId a log that ends with minImageTxId will be archived as well, ie not retained right? > Move edits log archiving logic into FSEditLog/JournalManager > ------------------------------------------------------------ > > Key: HDFS-2088 > URL: https://issues.apache.org/jira/browse/HDFS-2088 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node > Affects Versions: Edit log branch (HDFS-1073) > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Fix For: Edit log branch (HDFS-1073) > > Attachments: hdfs-2088.txt > > > Currently the logic to archive edits logs is File-specific which presents > some issues for Ivan's work. Since it relies on inspecting storage > directories using NNStorage.inspectStorageDirs, it also misses directories > that the image layer considers "failed" which results in edits logs piling up > in these kinds of directories. This JIRA is similar to HDFS-2018 but only > deals with archival for now. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira