[
https://issues.apache.org/jira/browse/HDFS-13192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377948#comment-16377948
]
LiXin Ge commented on HDFS-13192:
---------------------------------
Hi [~elgoiri], Thanks for your review.
{quote}The log doesn't seem to do so.
{quote}
Seems the jenkins didn't show the whole log, or just something about the log
mode, because the supposed log "Could not find encryption XAttr for file ..."
was shown in my local test. You can see it in the new attached log file
{{org.apache.hadoop.hdfs.TestEncryptionZones-output.txt}} and reproduce it in
your local machine with the command: {{mvn test
-Dtest=TestEncryptionZones#testSnapshotWithFile}}
{quote}I think we could just check the paths are equal here
{quote}
Yes, it's ought to be so. The {{getPath()}} returns {{String}} already, but
{{zone}} still have to call {{toString()}} method. I have done this in the
latest patch 003.
> change the code order in getFileEncryptionInfo to avoid unnecessary call of
> assignment
> --------------------------------------------------------------------------------------
>
> Key: HDFS-13192
> URL: https://issues.apache.org/jira/browse/HDFS-13192
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: encryption
> Affects Versions: 3.1.0
> Reporter: LiXin Ge
> Assignee: LiXin Ge
> Priority: Minor
> Attachments: HDFS-13192.001.patch, HDFS-13192.002.patch,
> org.apache.hadoop.hdfs.TestEncryptionZones-output.txt
>
>
> The assignment of {{version,suite}} and {{keyName}} should happen lazily,
> right before it's used in case the {{fileXAttr}} is *null*
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
