[ https://issues.apache.org/jira/browse/HDFS-13195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378393#comment-16378393 ]
genericqa commented on HDFS-13195: ---------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 11m 30s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} branch-2.7 Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 18s{color} | {color:green} branch-2.7 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 4s{color} | {color:green} branch-2.7 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 26s{color} | {color:green} branch-2.7 passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 6s{color} | {color:green} branch-2.7 passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 9s{color} | {color:green} branch-2.7 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 49s{color} | {color:green} branch-2.7 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 0s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 59s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 60 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 55s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}171m 3s{color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 2m 18s{color} | {color:red} The patch generated 308 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}211m 16s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Unreaped Processes | hadoop-hdfs:43 | | Failed junit tests | hadoop.hdfs.TestSetrepIncreasing | | | hadoop.hdfs.TestDFSRemove | | | hadoop.hdfs.TestFSOutputSummer | | | hadoop.hdfs.TestDFSFinalize | | | hadoop.hdfs.TestDisableConnCache | | | hadoop.hdfs.TestLease | | | hadoop.hdfs.TestHDFSTrash | | Timed out junit tests | org.apache.hadoop.hdfs.TestModTime | | | org.apache.hadoop.hdfs.TestSmallBlock | | | org.apache.hadoop.hdfs.TestWriteRead | | | org.apache.hadoop.fs.viewfs.TestViewFileSystemHdfs | | | org.apache.hadoop.hdfs.TestFileCreationEmpty | | | org.apache.hadoop.fs.TestEnhancedByteBufferAccess | | | org.apache.hadoop.hdfs.TestSetrepDecreasing | | | org.apache.hadoop.hdfs.TestClientProtocolForPipelineRecovery | | | org.apache.hadoop.hdfs.TestReplaceDatanodeOnFailure | | | org.apache.hadoop.hdfs.TestFileCreation | | | org.apache.hadoop.hdfs.TestFileAppend | | | org.apache.hadoop.hdfs.TestPread | | | org.apache.hadoop.hdfs.TestFsShellPermission | | | org.apache.hadoop.fs.viewfs.TestViewFileSystemAtHdfsRoot | | | org.apache.hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs | | | org.apache.hadoop.hdfs.TestDecommission | | | org.apache.hadoop.net.TestNetworkTopology | | | org.apache.hadoop.hdfs.TestReadWhileWriting | | | org.apache.hadoop.fs.viewfs.TestViewFileSystemWithTruncate | | | org.apache.hadoop.hdfs.TestEncryptionZonesWithKMS | | | org.apache.hadoop.hdfs.TestLeaseRecovery | | | org.apache.hadoop.tools.TestJMXGet | | | org.apache.hadoop.tracing.TestTracing | | | org.apache.hadoop.hdfs.TestLocalDFS | | | org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAcls | | | org.apache.hadoop.fs.viewfs.TestViewFileSystemWithXAttrs | | | org.apache.hadoop.hdfs.TestMissingBlocksAlert | | | org.apache.hadoop.fs.viewfs.TestViewFsWithAcls | | | org.apache.hadoop.hdfs.TestRenameWhileOpen | | | org.apache.hadoop.fs.TestUnbuffer | | | org.apache.hadoop.fs.contract.hdfs.TestHDFSContractCreate | | | org.apache.hadoop.fs.viewfs.TestViewFsWithXAttrs | | | org.apache.hadoop.hdfs.TestPersistBlocks | | | org.apache.hadoop.fs.contract.hdfs.TestHDFSContractSeek | | | org.apache.hadoop.fs.TestHDFSFileContextMainOperations | | | org.apache.hadoop.fs.permission.TestStickyBit | | | org.apache.hadoop.hdfs.TestGetBlocks | | | org.apache.hadoop.hdfs.TestDFSRename | | | org.apache.hadoop.hdfs.TestDataTransferProtocol | | | org.apache.hadoop.fs.contract.hdfs.TestHDFSContractAppend | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:ea57d10 | | JIRA Issue | HDFS-13195 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12912220/HDFS-13195-branch-2.7.001.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 8fdcaefb39e1 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | branch-2.7 / 1f2ab8b | | maven | version: Apache Maven 3.0.5 | | Default Java | 1.7.0_151 | | findbugs | v3.0.0 | | whitespace | https://builds.apache.org/job/PreCommit-HDFS-Build/23217/artifact/out/whitespace-eol.txt | | Unreaped Processes Log | https://builds.apache.org/job/PreCommit-HDFS-Build/23217/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-reaper.txt | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/23217/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/23217/testReport/ | | asflicense | https://builds.apache.org/job/PreCommit-HDFS-Build/23217/artifact/out/patch-asflicense-problems.txt | | Max. process+thread count | 8949 (vs. ulimit of 10000) | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/23217/console | | Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > DataNode conf page cannot display the current value after reconfig > ------------------------------------------------------------------- > > Key: HDFS-13195 > URL: https://issues.apache.org/jira/browse/HDFS-13195 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode > Affects Versions: 2.7.1 > Reporter: maobaolong > Priority: Minor > Fix For: 2.7.1 > > Attachments: HDFS-13195-branch-2.7.001.patch, HDFS-13195.001.patch > > > Now the branch-2.7 support dfs.datanode.data.dir reconfig, but after i > reconfig this key, the conf page's value is still the old config value. > The reason is that: > {code:java} > public DatanodeHttpServer(final Configuration conf, > final DataNode datanode, > final ServerSocketChannel externalHttpChannel) > throws IOException { > this.conf = conf; > Configuration confForInfoServer = new Configuration(conf); > confForInfoServer.setInt(HttpServer2.HTTP_MAX_THREADS, 10); > HttpServer2.Builder builder = new HttpServer2.Builder() > .setName("datanode") > .setConf(confForInfoServer) > .setACL(new AccessControlList(conf.get(DFS_ADMIN, " "))) > .hostName(getHostnameForSpnegoPrincipal(confForInfoServer)) > .addEndpoint(URI.create("http://localhost:0")) > .setFindPort(true); > this.infoServer = builder.build(); > {code} > The confForInfoServer is a new configuration instance, while the dfsadmin > reconfig the datanode's config, the config result cannot reflect to > confForInfoServer, so we should use the datanode's conf. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org