[ https://issues.apache.org/jira/browse/HDFS-13212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388945#comment-16388945 ]
Íñigo Goiri commented on HDFS-13212: ------------------------------------ Thanks [~wuweiwei] for [^HDFS-13212-005.patch]. It probably makes sense but I cannot figure it out, can you go in detail into: {code} 246 } else { 247 String dest = loc.getDefaultLocation().getDest(); 248 if (dest.startsWith(path)) { 249 LOG.debug("Removing default cache {}", dest); 250 it.remove(); 251 } 252 } {code} When is {{invalidateLocationCache()}} called with an scenario that would give a null in the source? And why do we check the default location? Is this case tested in the unit test? > RBF: Fix router location cache issue > ------------------------------------ > > Key: HDFS-13212 > URL: https://issues.apache.org/jira/browse/HDFS-13212 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: federation, hdfs > Reporter: Weiwei Wu > Priority: Major > Attachments: HDFS-13212-001.patch, HDFS-13212-002.patch, > HDFS-13212-003.patch, HDFS-13212-004.patch, HDFS-13212-005.patch > > > The MountTableResolver refreshEntries function have a bug when add a new > mount table entry which already have location cache. The old location cache > will never be invalid until this mount point change again. > Need to invalid the location cache when add the mount table entries. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org