[
https://issues.apache.org/jira/browse/HDFS-13224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394410#comment-16394410
]
Yiqun Lin commented on HDFS-13224:
----------------------------------
Have taken a deep review, some comments (Most for unit test):
*LocalResolver.java*
1.
{quote}I left out the one about the mapping update because I'm not sure what a
good period would be.
In our deployment we can get large chunks of DNs changing subclusters after
reimaging.
This is not super common (once a day is reasonable actually) but we would like
to catch those when they happen.
{quote}
I suggest to add a {{TODO}} comment indicate that we can improve this later by
making this period configurable.
{code:java}
+ /** Minimum time in ms to update the local cache. 10 seconds by default. */
// TODO:...
+ private static final long MIN_UPDATE_PERIOD = TimeUnit.SECONDS.toMillis(10);
{code}
2.line255. We can use util class {{HostAndPort.fromString(addr).getHostText()}}
to parse host name from given address string.
*TestMultipleDestinationResolver.java*
1. line85. No tests used for testing {{LocalResolver}}.
2.line103.Read only mount point also doesn't be tested, what's the test case
to do for this?
3.line222. {{for (int f=0; f<100; f++) {}} needs the space in {{=}}, {{<}}.
4. We need a corner test for the case that
{{OrderedResolver.getFirstNamespace}} doesn't find the first namespace. And
verify the correctness of {{PathLocation}} returned by
{{MultipleDestinationMountTableResolver.getDestinationForPath(String path)}}.
Others look good.
> RBF: Resolvers to support mount points across multiple subclusters
> ------------------------------------------------------------------
>
> Key: HDFS-13224
> URL: https://issues.apache.org/jira/browse/HDFS-13224
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: Íñigo Goiri
> Priority: Major
> Attachments: HDFS-13224.000.patch, HDFS-13224.001.patch,
> HDFS-13224.002.patch, HDFS-13224.003.patch, HDFS-13224.004.patch,
> HDFS-13224.005.patch
>
>
> Currently, a mount point points to a single subcluster. We should be able to
> spread files in a mount point across subclusters.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
