[
https://issues.apache.org/jira/browse/HDFS-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054627#comment-13054627
]
Todd Lipcon commented on HDFS-2092:
-----------------------------------
I see a couple of good reasons for the change:
- changing a conf object underneath a DFSClient won't change its behavior
- we no longer have to worry about that deadlock bug of synchronized (conf) {
conf.writeToXml(dfsOutputStream); }
But the memory leak argument seems strange. For TIP/JIP, those classes already
keep a reference to JobConf. So eliminating this reference to the object
shouldn't have any effect on memory usage, right? Or is the issue that we're
leaking FileSystem objects into the FS Cache in the TT/JT? In that case, we
ought to fix that leak too.
> Create a light inner conf class in DFSClient
> --------------------------------------------
>
> Key: HDFS-2092
> URL: https://issues.apache.org/jira/browse/HDFS-2092
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs client
> Affects Versions: 0.23.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Fix For: 0.23.0
>
> Attachments: HDFS-2092-1.patch, HDFS-2092-2.patch
>
>
> At present, DFSClient stores reference to configuration object. Since, these
> configuration objects are pretty big at times can blot the processes which
> has multiple DFSClient objects like in TaskTracker. This is an attempt to
> remove the reference of conf object in DFSClient.
> This patch creates a light inner conf class and copies the required keys from
> the Configuration object.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
