[ 
https://issues.apache.org/jira/browse/HDFS-13314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406753#comment-16406753
 ] 

Arpit Agarwal commented on HDFS-13314:
--------------------------------------

Thanks for the look [~xiaochen]. 
bq. I'm inclined to agree with Arpit that we should not change the default 
behavior, though. In the extreme case where someone really wants the checkpoint 
done (e.g. has not checkpointed for a long time so lots of edits, etc.), 
keeping the old behavior seems better - you cannot let them reconfigure and do 
it again.
Yes, this is a good explanation. Not changing the default, and ensuring we 
write a new image is the safe choice.

Also thanks for the feedback [~szetszwo], I will post an updated patch shortly 
to address your comments. Running some sanity tests first.

> NameNode should optionally exit if it detects FsImage corruption
> ----------------------------------------------------------------
>
>                 Key: HDFS-13314
>                 URL: https://issues.apache.org/jira/browse/HDFS-13314
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>            Priority: Major
>         Attachments: HDFS-13314.01.patch, HDFS-13314.02.patch
>
>
> The NameNode should optionally exit after writing an FsImage if it detects 
> the following kinds of corruptions:
> # INodeReference pointing to non-existent INode
> # Duplicate entries in snapshot deleted diff list.
> This behavior is controlled via an undocumented configuration setting, and 
> disabled by default.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to