[
https://issues.apache.org/jira/browse/HDFS-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055276#comment-13055276
]
Hadoop QA commented on HDFS-979:
--------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12483882/HDFS-979-take2.txt
against trunk revision 1139715.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/845//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/845//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/845//console
This message is automatically generated.
> FSImage should specify which dirs are missing when refusing to come up
> ----------------------------------------------------------------------
>
> Key: HDFS-979
> URL: https://issues.apache.org/jira/browse/HDFS-979
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 0.22.0
> Reporter: Steve Loughran
> Assignee: Jim Plush
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HDFS-979-take1.txt, HDFS-979-take2.txt
>
>
> When {{FSImage}} can't come up as either it has no data or edit dirs, it
> tells me this
> {code}
> java.io.IOException: All specified directories are not accessible or do not
> exist.
> {code}
> What it doesn't do is say which of the two attributes are missing. This would
> be beneficial to anyone trying to track down the problem. Also, I don't think
> the message is correct. It's bailing out because dataDirs.size() == 0 ||
> editsDirs.size() == 0 , because a list is empty -not because the dirs aren't
> there, as there hasn't been any validation yet.
> More useful would be
> # Explicit mention of which attributes are null
> # Declare that this is because they are not in the config
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
