[ 
https://issues.apache.org/jira/browse/HDFS-13175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16409044#comment-16409044
 ] 

Yongjun Zhang edited comment on HDFS-13175 at 3/22/18 4:51 AM:
---------------------------------------------------------------

Thanks for the work here [~eddyxu] and [~anu]. Saw 

https://issues.apache.org/jira/browse/HDFS-13034?focusedCommentId=16331614&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16331614

wonder if it's related.



was (Author: yzhangal):
Thanks for the work here [~eddyxu]. Saw 

https://issues.apache.org/jira/browse/HDFS-13034?focusedCommentId=16331614&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16331614

wonder if it's related.


> Add more information for checking argument in DiskBalancerVolume
> ----------------------------------------------------------------
>
>                 Key: HDFS-13175
>                 URL: https://issues.apache.org/jira/browse/HDFS-13175
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: diskbalancer
>    Affects Versions: 3.0.0
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>            Priority: Minor
>             Fix For: 3.1.0, 3.0.2
>
>         Attachments: HDFS-13175.00.patch, HDFS-13175.01.patch
>
>
> We have seen the following stack in production
> {code}
> Exception in thread "main" java.lang.IllegalArgumentException
>       at 
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:72)
>       at 
> org.apache.hadoop.hdfs.server.diskbalancer.datamodel.DiskBalancerVolume.setUsed(DiskBalancerVolume.java:268)
>       at 
> org.apache.hadoop.hdfs.server.diskbalancer.connectors.DBNameNodeConnector.getVolumeInfoFromStorageReports(DBNameNodeConnector.java:141)
>       at 
> org.apache.hadoop.hdfs.server.diskbalancer.connectors.DBNameNodeConnector.getNodes(DBNameNodeConnector.java:90)
>       at 
> org.apache.hadoop.hdfs.server.diskbalancer.datamodel.DiskBalancerCluster.readClusterInfo(DiskBalancerCluster.java:132)
>       at 
> org.apache.hadoop.hdfs.server.diskbalancer.command.Command.readClusterInfo(Command.java:123)
>       at 
> org.apache.hadoop.hdfs.server.diskbalancer.command.PlanCommand.execute(PlanCommand.java:107)
> {code}
> raised from 
> {code}
>  public void setUsed(long dfsUsedSpace) {
>     Preconditions.checkArgument(dfsUsedSpace < this.getCapacity());
>     this.used = dfsUsedSpace;
>   }
> {code}
> However, the datanode reports at the very moment were not captured. We should 
> add more information into the stack trace to better diagnose the issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to