[ https://issues.apache.org/jira/browse/HDFS-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413116#comment-16413116 ]
Íñigo Goiri commented on HDFS-13204: ------------------------------------ The import approach for the CSS in [^HDFS-13204.007.patch] looks good. Just one minor comment, there is a change in the last line of federationhealth.html which could be avoided. Other than that +1. [~ywskycn] any further comments? For the read only icon I would go with a lock (like glyphicon-lock which is \e033) or similar but you call it. Actually, internally, we had: {code} .dfshealth-mount-read-only-true:before { color: #c7254e; content: "\e033"; } .dfshealth-mount-read-only-false:before { color: #5fa341; content: "\e013"; } {code} > RBF: Optimize name service safe mode icon > ----------------------------------------- > > Key: HDFS-13204 > URL: https://issues.apache.org/jira/browse/HDFS-13204 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: liuhongtong > Assignee: liuhongtong > Priority: Minor > Attachments: HDFS-13204.001.patch, HDFS-13204.002.patch, > HDFS-13204.003.patch, HDFS-13204.004.patch, HDFS-13204.005.patch, > HDFS-13204.006.patch, HDFS-13204.007.patch, Routers.png, Subclusters.png, > image-2018-02-28-18-33-09-972.png, image-2018-02-28-18-33-47-661.png, > image-2018-02-28-18-35-35-708.png, image-2018-03-23-18-06-54-354.png > > > In federation health webpage, the safe mode icons of Subclusters and Routers > are inconsistent. > The safe mode icon of Subclusters may induce users the name service is > maintaining. > !image-2018-02-28-18-33-09-972.png! > The safe mode icon of Routers: > !image-2018-02-28-18-33-47-661.png! > In fact, if the name service is in safe mode, users can't do writing related > operations. So I think the safe mode icon in Subclusters should be modified, > which may be more reasonable. > !image-2018-02-28-18-35-35-708.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org