[ https://issues.apache.org/jira/browse/HDFS-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056375#comment-13056375 ]
Hadoop QA commented on HDFS-2110: --------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12484399/hdfs-2110-2.patch against trunk revision 1140030. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/858//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/858//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/858//console This message is automatically generated. > Some StreamFile and ByteRangeInputStream cleanup > ------------------------------------------------ > > Key: HDFS-2110 > URL: https://issues.apache.org/jira/browse/HDFS-2110 > Project: Hadoop HDFS > Issue Type: Improvement > Components: name-node > Reporter: Eli Collins > Assignee: Eli Collins > Priority: Minor > Fix For: 0.23.0 > > Attachments: hdfs-2110-1.patch, hdfs-2110-2.patch > > > StreamFile#sendPartialData can be cleaned up, has some System.out.printlns, > no javadoc, and the byte copying method should be pulled out to IOUtils. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira