[ https://issues.apache.org/jira/browse/HDFS-8979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414061#comment-16414061 ]
Rushabh S Shah edited comment on HDFS-8979 at 3/26/18 4:11 PM: --------------------------------------------------------------- This patch also broke HDFS-13330. Already this patch introduced 3 major bugs. Behind such benign jira description (i.e fixing checkstyle issues), it broke 3 functionalities. I am worried that how many more bugs are hidden by this patch ? I completely understand the good intention behind this jira but I would rather live with checkstyle warnings compared to broken functionality. Unless someone volunteers to review such huge patch again, I am inclined to revert this patch from all branches. I would appreciate opinions from other members. was (Author: shahrs87): This patch also broke HDFS-13330. Already this patch introduced 3 major bugs. Behind such benign jira description (i.e fixing checkstyle issues), it broke 3 functionalities. I am worried that how many more bugs are hidden by this patch ? I completely understand the good intention behind this jira but I would rather live with checkstyle warnings compared to broken functionality. If someone volunteers to review such huge patch again, I am inclined to revert from all branches. I would appreciate opinions from other members. > Clean up checkstyle warnings in hadoop-hdfs-client module > --------------------------------------------------------- > > Key: HDFS-8979 > URL: https://issues.apache.org/jira/browse/HDFS-8979 > Project: Hadoop HDFS > Issue Type: Task > Reporter: Mingliang Liu > Assignee: Mingliang Liu > Priority: Major > Fix For: 2.8.0, 3.0.0-alpha1 > > Attachments: HDFS-8979.000.patch, HDFS-8979.001.patch, > HDFS-8979.002.patch > > > This jira tracks the effort of cleaning up checkstyle warnings in > {{hadoop-hdfs-client}} module. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org