[ https://issues.apache.org/jira/browse/HDFS-13087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415073#comment-16415073 ]
Xiao Chen edited comment on HDFS-13087 at 3/27/18 6:11 AM: ----------------------------------------------------------- Thanks for revving [~GeLiXin]. Latest patch looks pretty good. +1 pending 1 comment: We can reduce some duplication between the 2 {{XAttrStorage#readINodeXAttrByPrefixedName}} methods. Can have the method that takes iip to call the method with inode and snapshotId, something like {{return readINodeXAttrByPrefixedName(iip.getLastINode(), iip.getPathSnapshotId(), prefixedName);}}. (javadoc of that method look stale too, would be good to clean it up while you're at it.) was (Author: xiaochen): Thanks for revving [~GeLiXin]. Latest patch looks pretty good. +1 pending 1 comment: We can reduce some duplication between the 2 {{XAttrStorage#readINodeXAttrByPrefixedName}} methods. Can have the method that takes iip to call the method with inode and snapshotId, something like {{return readINodeXAttrByPrefixedName(iip.getLastINode(), iip.getPathSnapshotId(), prefixedName);}}. (javadoc of that method look stale too, would be good to clean it up while you're at it. > Fix: Snapshots On encryption zones get incorrect EZ settings when encryption > zone changes > ----------------------------------------------------------------------------------------- > > Key: HDFS-13087 > URL: https://issues.apache.org/jira/browse/HDFS-13087 > Project: Hadoop HDFS > Issue Type: Bug > Components: encryption > Affects Versions: 3.1.0 > Reporter: LiXin Ge > Assignee: LiXin Ge > Priority: Major > Attachments: HDFS-13087.001.patch, HDFS-13087.002.patch, > HDFS-13087.003.patch, HDFS-13087.004.patch > > > Snapshots are supposed to be immutable and read only, so the EZ settings > which in a snapshot path shouldn't change when the origin encryption zone > changes. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org