[ 
https://issues.apache.org/jira/browse/HDFS-13314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416046#comment-16416046
 ] 

Rushabh S Shah commented on HDFS-13314:
---------------------------------------

bq. perhaps we could do some ugly fault injection to create dangling references 
and corrupted diff lists in the image.
I am not that much concerned with the test case showing how the image is 
corrupted.
I would like to see a test case to verify the following 2 scenarios
* if numErrors == 0 then namenode should not exit.
* if numErrors > 0 then namenode should exit. 
Quickly going through ExitUtil class, I see you can use 
{{ExitUtil#disableSystemExit}}.
This will save the exception somewhere in ExitUtil class. 
{{ExitUtil#terminate}} will throw an {{ExitException}}.
Hope this helps.

> NameNode should optionally exit if it detects FsImage corruption
> ----------------------------------------------------------------
>
>                 Key: HDFS-13314
>                 URL: https://issues.apache.org/jira/browse/HDFS-13314
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>            Priority: Major
>         Attachments: HDFS-13314.01.patch, HDFS-13314.02.patch, 
> HDFS-13314.03.patch, HDFS-13314.04.patch, HDFS-13314.05.patch
>
>
> The NameNode should optionally exit after writing an FsImage if it detects 
> the following kinds of corruptions:
> # INodeReference pointing to non-existent INode
> # Duplicate entries in snapshot deleted diff list.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to