[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421160#comment-16421160
]
Xiao Chen commented on HDFS-13281:
----------------------------------
Thanks Rushabh.
bq. Is there anything you expect me to change in the latest trunk patch ?
2 things:
- Current test is logically correct. But for readability I'd prefer we do the
test like this:
# write the file
# read from reserved raw to get the raw bytes, verify it's different than input
# write the raw bytes to a new file via /.reserved/raw, read that via
/.reserved/raw, verify it's the same as step 2.
- close the streams.
I'm +1 pending the above 2.
You can also skip the branch-2 patch, since that's only import conflicts in the
test. This rule is there to ensure quality. You can expect minor conflicts been
handled correctly, and committers would compile locally before pushing.
bq. I didn't get enough cycles to write a design doc.
Appreciate the explanation and the promise. I think having it ready would save
time for everyone in the long run. Surely it will help all the reviewers, and
it may also save you some time if you ever page out. :)
> Namenode#createFile should be /.reserved/raw/ aware.
> ----------------------------------------------------
>
> Key: HDFS-13281
> URL: https://issues.apache.org/jira/browse/HDFS-13281
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: encryption
> Affects Versions: 2.8.3
> Reporter: Rushabh S Shah
> Assignee: Rushabh S Shah
> Priority: Critical
> Attachments: HDFS-13281.001.patch, HDFS-13281.002.branch-2.patch,
> HDFS-13281.002.patch
>
>
> If I want to write to /.reserved/raw/<dir> and if that directory happens to
> be in EZ, then namenode *should not* create edek and just copy the raw bytes
> from the source.
> Namenode#startFileInt should be /.reserved/raw/ aware.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
