[
https://issues.apache.org/jira/browse/HDFS-13364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422056#comment-16422056
]
Yiqun Lin commented on HDFS-13364:
----------------------------------
[~elgoiri], seemed you attached a incorrect patch and didn't include the change
as mentioned. So I did a deep review based on v003 patch. Following are my
review comments, almost looks great:
*ConnectionPool.java*
# One typo: {{Mostly based on NameNodeProxies#createNonHAProxy() but it
need..}} should be {{Mostly based on NameNodeProxies#createNonHAProxy() but it
needs}}.
*TestRouterRpc.java*
# Can we update the comment {{Client interface to the Namenode.}} to {{Client
interface to the default Namenode.}}? This will look more accurate.
# In test method {{testProxyVersionRequest}}, {{testProxyGetBlockKeys}} and
{{testProxyGetBlocks}}, the values returned by routerNamenodeProtocol should be
the actual value in {{assertEquals}} comparisons.
Please attach a clean patch and address these comments as well, :).
> RBF: Support NamenodeProtocol in the Router
> -------------------------------------------
>
> Key: HDFS-13364
> URL: https://issues.apache.org/jira/browse/HDFS-13364
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: Íñigo Goiri
> Priority: Major
> Attachments: HDFS-13364.000.patch, HDFS-13364.001.patch,
> HDFS-13364.002.patch, HDFS-13364.003.patch, HDFS-13365.004.patch
>
>
> The Router should support the NamenodeProtocol to get blocks, versions, etc.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
