[ https://issues.apache.org/jira/browse/HDFS-13395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428823#comment-16428823 ]
Nanda kumar commented on HDFS-13395: ------------------------------------ Thanks [~elek] and [~shashikant] for reviewing the patch. I have addressed the review comments in v001. bq. Can we just remove it... Removed DataNodeServicePlugin. bq. There is a typo... Fixed. bq. Please also update the docker-compose file in... Done. bq. I would add additional check to the OzoneHdslDatanodeService.start()... Added error level log message stating that plugin will not be started unless invoked through {{HddsDatanodeService}} bq. I would consider to make it as a default value... Done. Since the renaming of ObjectStoreRestPlugin is also handled in this jira, we can resolve HDFS-13325 as duplicate once this is committed. > Ozone: Plugins support in HDSL Datanode Service > ----------------------------------------------- > > Key: HDFS-13395 > URL: https://issues.apache.org/jira/browse/HDFS-13395 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone > Reporter: Nanda kumar > Assignee: Nanda kumar > Priority: Major > Attachments: HDFS-13395-HDFS-7240.000.patch, > HDFS-13395-HDFS-7240.001.patch > > > As part of Datanode, we start {{HdslDatanodeService}} if {{ozone}} is > enabled. We need provision to load plugins like {{Ozone Rest Service}} as > part of {{HdslDatanodeService}} start. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org