[ https://issues.apache.org/jira/browse/HDFS-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058114#comment-13058114 ]
Hadoop QA commented on HDFS-2109: --------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12484829/HDFS-2109-2.patch against trunk revision 1141713. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.server.namenode.TestStartup org.apache.hadoop.hdfs.TestFileCreationClient +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/874//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/874//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/874//console This message is automatically generated. > Store uMask as member variable to DFSClient.Conf > ------------------------------------------------ > > Key: HDFS-2109 > URL: https://issues.apache.org/jira/browse/HDFS-2109 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs client > Affects Versions: 0.23.0 > Reporter: Bharath Mundlapudi > Assignee: Bharath Mundlapudi > Fix For: 0.23.0 > > Attachments: HDFS-2109-1.patch, HDFS-2109-2.patch > > > As a part of removing reference to conf in DFSClient, I am proposing > replacing FsPermission.getUMask(conf) everywhere in DFSClient class with > dfsClientConf.uMask by storing uMask as a member variable to DFSClient.Conf. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira