[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433151#comment-16433151
]
Plamen Jeliazkov edited comment on HDFS-13399 at 4/10/18 11:24 PM:
-------------------------------------------------------------------
Hey [~xkrogen], thanks for the review! Here's what I found:
(1) I am not sure if that Javadoc link error is related to my changes. I did
not modify {{NameNodeProxies#createProxy(Configuration, URI, Class)}} and with
my changes shelved / removed I still see the Javadoc link error on
{{NameNodeProxiesClient#createProxyWithClientProtocol}}. Unless you are
referring to something else I am not sure what I missed...
(2) I agree they appear related. Took a quick look. It seems
{{Client.createCall(RPC.RpcKind rpcKind, Writable rpcRequest)}} is now unused
in favor of the overloaded method that adds {{AlignmentContext}} as a
parameter. Should I just delete {{Client.createCall(RPC.RpcKind rpcKind,
Writable rpcRequest)}} or should I modify TestIPC and TestAsyncIPC to call the
new method? I would vote to remove the two parameter method and update the
tests as it really seems it is just unused now.
(3) I will apply your changes in a next patch; I also have made some test
optimizations on my own as well – mostly around removing unneeded
{{cluster.waitActive()}} calls.
As for the configuration question – it was more-so just out of curiosity to see
if you guys wanted this to just be a standard feature of {{DFSClients}} and
{{FSNamesystem}} going forward or if you wanted to try to preserve the legacy
behavior. I agree overhead is very minimal; I would say in both processing and
payload. I can only think it may be useful to revert to "old behavior" in the
event that there is ever some crippling bug in the client or server side of the
RPC processing. I would vote to make it a standard feature, but again, I wanted
to ask and see your opinions.
was (Author: zero45):
(1) I am not sure if that Javadoc link error is related to my changes. I did
not modify {{NameNodeProxies#createProxy(Configuration, URI, Class)}} and with
my changes shelved / removed I still see the Javadoc link error on
{{NameNodeProxiesClient#createProxyWithClientProtocol}}. Unless you are
referring to something else I am not sure what I missed...
(2) I agree they appear related. Took a quick look. It seems
{{Client.createCall(RPC.RpcKind rpcKind, Writable rpcRequest)}} is now unused
in favor of the overloaded method that adds {{AlignmentContext}} as a
parameter. Should I just delete {{Client.createCall(RPC.RpcKind rpcKind,
Writable rpcRequest)}} or should I modify TestIPC and TestAsyncIPC to call the
new method? I would vote to remove the two parameter method and update the
tests as it really seems it is just unused now.
(3) I will apply your changes in a next patch; I also have made some test
optimizations on my own as well – mostly around removing unneeded
{{cluster.waitActive()}} calls.
As for the configuration question – it was more-so just out of curiosity to see
if you guys wanted this to just be a standard feature of {{DFSClients}} and
{{FSNamesystem}} going forward or if you wanted to try to preserve the legacy
behavior. I agree overhead is very minimal; I would say in both processing and
payload. I can only think it may be useful to revert to "old behavior" in the
event that there is ever some crippling bug in the client or server side of the
RPC processing. I would vote to make it a standard feature, but again, I wanted
to ask and see your opinions.
> Make Client field AlignmentContext non-static.
> ----------------------------------------------
>
> Key: HDFS-13399
> URL: https://issues.apache.org/jira/browse/HDFS-13399
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-12943
> Reporter: Plamen Jeliazkov
> Assignee: Plamen Jeliazkov
> Priority: Major
> Attachments: HDFS-13399-HDFS-12943.000.patch,
> HDFS-13399-HDFS-12943.001.patch
>
>
> In HDFS-12977, DFSClient's constructor was altered to make use of a new
> static method in Client that allowed one to set an AlignmentContext. This
> work is to remove that static field and make each DFSClient pass it's
> AlignmentContext down to the proxy Call level.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
