[
https://issues.apache.org/jira/browse/HDFS-13423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433960#comment-16433960
]
Mukul Kumar Singh commented on HDFS-13423:
------------------------------------------
Thanks for working on this [~nandakumar131].
After this change, the number of changes in hdfs is limited to 6 files.
{code}
HW13605:ozone_review2 msingh$ grep "diff --git a/hadoop-hdfs-project"
../branch_diff
diff --git
a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/RestCsrfPreventionFilterHandler.java
b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/RestCsrfPreventionFilterHandler.java
diff --git
a/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode/datanode.html
b/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode/datanode.html
diff --git
a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
diff --git
a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSClusterWithNodeGroup.java
b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSClusterWithNodeGroup.java
diff --git
a/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-22-dfs-dir.tgz
b/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-22-dfs-dir.tgz
diff --git
a/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties
b/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties
{code}
Couple of comments.
1) HddsDatanodeService:26, unused import
2) MiniOzoneClassicCluster:339: extra line
3) MiniOzoneTestHelper.java:73-77, lets have two different exceptions. One
where no plugins are found and the second where we propagate the error
correctly.
4) RestCsrfPreventionFilterHandler:46, the change can be converted to "final
class RestCsrfPreventionFilterHandler"
> Ozone: Clean-up of ozone related change from hadoop-hdfs-project
> ----------------------------------------------------------------
>
> Key: HDFS-13423
> URL: https://issues.apache.org/jira/browse/HDFS-13423
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Nanda kumar
> Assignee: Nanda kumar
> Priority: Major
> Attachments: HDFS-13423-HDFS-7240.000.patch
>
>
> This jira is for tracking the clean-up and rever the changes made in
> hadoop-hdfs-project which are related to ozone.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
