[ 
https://issues.apache.org/jira/browse/HDFS-13413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435240#comment-16435240
 ] 

Nanda kumar commented on HDFS-13413:
------------------------------------

Thanks [~shashikant] for working on this.
Just a small suggestion, instead of comparing {{datanodeUUID}} as string we can 
convert it to UUID using {{UUID.fromString(uuid-string)}} and compare it.

> ClusterId and DatanodeUuid should be marked mandatory fileds in 
> SCMRegisteredCmdResponseProto
> ---------------------------------------------------------------------------------------------
>
>                 Key: HDFS-13413
>                 URL: https://issues.apache.org/jira/browse/HDFS-13413
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Shashikant Banerjee
>            Assignee: Shashikant Banerjee
>            Priority: Minor
>             Fix For: HDFS-7240
>
>         Attachments: HDFS-13413-HDFS-7240.000.patch, 
> HDFS-13413-HDFS-7240.001.patch
>
>
> ClusterId as well as the DatanodeUuid are optional fields in 
> {{SCMRegisteredCmdResponseProto}}
> currently. We have to make both clusterId and DatanodeUuid as required field 
> and handle it properly. As of now, we don't do anything with the response of 
> datanode registration. We should validate the clusterId and also the 
> datanodeUuid



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to