[ https://issues.apache.org/jira/browse/HDFS-13197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439163#comment-16439163 ]
Nanda kumar commented on HDFS-13197: ------------------------------------ Sorry for reviewing it so late. I just have a concern about the property names that is been introduced. Since the property name starts with {{hadoop.custom}} and {{ozone.system}} it sounds like we are referring to all the custom hadoop properties and all the system related ozone properties. Can we rename it to {{ozone.tags.custom}} and {{ozone.tags.system}}? this sounds more like properties related to tags. This can be done as part of HDFS-13449 or we can even create a new jira for this change. > Ozone: Fix ConfServlet#getOzoneTags cmd > --------------------------------------- > > Key: HDFS-13197 > URL: https://issues.apache.org/jira/browse/HDFS-13197 > Project: Hadoop HDFS > Issue Type: Sub-task > Affects Versions: HDFS-7240 > Reporter: Xiaoyu Yao > Assignee: Ajay Kumar > Priority: Major > Fix For: HDFS-7240 > > Attachments: HDFS-13197-HDFS-7240.000.patch, > HDFS-13197-HDFS-7240.001.patch, HDFS-13197-HDFS-7240.002.patch, > HDFS-13197-HDFS-7240.003.patch, Screen Shot 2018-04-10 at 2.05.35 PM.png > > > This is broken after merging trunk change HADOOP-15007 into HDFS-7240 branch. > I remove the cmd and related test to have a clean merge. [~ajakumar], please > fix the cmd and bring back the related test. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org