[
https://issues.apache.org/jira/browse/HDFS-13478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443733#comment-16443733
]
Yiqun Lin edited comment on HDFS-13478 at 4/19/18 8:32 AM:
-----------------------------------------------------------
Some reviews comments for the v001 patch:
* The change for MembershipNamenodeResolver can be removed in the another JIRA.
* The javadoc of {{DecommissionStoreImpl}} is wrong,
{{FederationDecommisionNamespaceStore}} doesn't exist.
{noformat}
Implementation of {@link FederationDecommisionNamespaceStore}.
{noformat}
*DecommissionedNamespace .java*
line90: The filed user name should also be one part of primary keys.
line96: Here no expiration needed, can we change the value to -1, that will be
consistent in no-expiration needed type BaseRecord (like StateStoreVersion).
*TestRouterAdmin.java*
line383: Why we uncomment this check?
One improvement for the access of disabled namespaces, the namespaces disabled
by R1 admin won't make sense to the RPC invoked in R2. Currently we assume the
user is completely same, a better way we would use the Router admin user passed
into primary keys and do the filtering for users when querying from State
Store. [~elgoiri], I can make this improvement if you also agree this proposal.
was (Author: linyiqun):
Some reviews comments for the v001 patch:
* The change for MembershipNamenodeResolver can be removed in the another JIRA.
* The javadoc of {{DecommissionStoreImpl}} is wrong,
{{FederationDecommisionNamespaceStore}} doesn't exist.
{noformat}
Implementation of {@link FederationDecommisionNamespaceStore}.
{noformat}
*DecommissionedNamespace .java*
line90: The filed user name should also be one part of primary keys.
line96: Here no expiration needed, can we change the value to -1, that will be
consistent in no-expiration needed type BaseRecord.
*TestRouterAdmin.java*
line383: Why we uncomment this check?
One improvement for the access of disabled namespaces, the namespaces disabled
by R1 admin won't make sense to the RPC invoked in R2. Currently we assume the
user is completely same, a better way we would use the Router admin user passed
into primary keys and do the filtering for users when querying from State
Store. [~elgoiri], I can make this improvement if you also agree this proposal.
> RBF: Decommission subclusters from the federation
> -------------------------------------------------
>
> Key: HDFS-13478
> URL: https://issues.apache.org/jira/browse/HDFS-13478
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: Íñigo Goiri
> Priority: Major
> Attachments: HDFS-13478.000.patch, HDFS-13478.001.patch
>
>
> We have a subcluster in our federation that is for testing and is
> missbehaving. This has a negative impact on the performance with operations
> that go to every subcluster (e.g., renewLease() or setSafeMode()).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
