[
https://issues.apache.org/jira/browse/HDFS-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060822#comment-13060822
]
Jitendra Nath Pandey commented on HDFS-2018:
--------------------------------------------
Some comments:
1. FileJournalManager.java
getMaxLoadableTransaction can be made private.
2. JournalManager interface
Instead of adding archiveLogsOlderThan to the interface, we could add
purgeTransactions method (as in HDFS-1580 design). FileJournalManager could
implement purgeTransactions using archives, i.e. instead of really deleting, it
archives them. Since Checkpoints are being archived, we don't need to force any
JournalManager to archive edit logs as well.
Apart from the above, the patch looks good to me. +1
> Move all journal stream management code into one place
> ------------------------------------------------------
>
> Key: HDFS-2018
> URL: https://issues.apache.org/jira/browse/HDFS-2018
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: Edit log branch (HDFS-1073)
>
> Attachments: HDFS-2018.diff, HDFS-2018.diff, HDFS-2018.diff,
> HDFS-2018.diff, HDFS-2018.diff, HDFS-2018.diff, HDFS-2018.diff, HDFS-2018.diff
>
>
> Currently in the HDFS-1073 branch, the code for creating output streams is in
> FileJournalManager and the code for input streams is in the inspectors. This
> change does a number of things.
> - Input and Output streams are now created by the JournalManager.
> - FSImageStorageInspectors now deals with URIs when referring to edit logs
> - Recovery of inprogress logs is performed by counting the number of
> transactions instead of looking at the length of the file.
> The patch for this applies on top of the HDFS-1073 branch + HDFS-2003 patch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
