[
https://issues.apache.org/jira/browse/HDFS-9593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16444889#comment-16444889
]
genericqa commented on HDFS-9593:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color}
| {color:red} HDFS-9593 does not apply to trunk. Rebase required? Wrong Branch?
See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HDFS-9593 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12779145/BlockTokenIdentifier.HDFS-9593.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/24004/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> BlockTokenIdentifier Code Review
> --------------------------------
>
> Key: HDFS-9593
> URL: https://issues.apache.org/jira/browse/HDFS-9593
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Trivial
> Attachments: BlockTokenIdentifier.HDFS-9593.patch
>
>
> Please find attached a code review of BlockTokenIdentifier.
> The only real change is using an explicit StringBuilder instead of an
> implicit one so that the internal buffer may be set more appropriately and
> checking for zero-length string instead of comparing to an empty string. The
> relatively small default buffer of 16 bytes would need to be expanded several
> times to fit the incoming string.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
