[ https://issues.apache.org/jira/browse/HDFS-13381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445356#comment-16445356 ]
Chris Douglas commented on HDFS-13381: -------------------------------------- [~daryn]: to over-simplify [~rakeshr]'s description, the {{IntraSPSNameNodeFileIdCollector}} adds additional logic is for batching i.e., implementing {{FSTreeTraverser}} hooks, borrowing the pattern from encryption zones. The external/internal separation seems intact, as both {{FileCollector}} implementations are only accessible through their respective {{Context}}. This might be emphasized by removing the {{FileCollector}} interface, since it serves no particular purpose. Would that be sufficient? > [SPS]: Use DFSUtilClient#makePathFromFileId() to prepare satisfier file path > ---------------------------------------------------------------------------- > > Key: HDFS-13381 > URL: https://issues.apache.org/jira/browse/HDFS-13381 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Rakesh R > Assignee: Rakesh R > Priority: Major > Attachments: HDFS-13381-HDFS-10285-00.patch, > HDFS-13381-HDFS-10285-01.patch > > > This Jira task will address the following comments: > # Use DFSUtilClient::makePathFromFileId, instead of generics(one for string > path and another for inodeId) like today. > # Only the context impl differs for external/internal sps. Here, it can > simply move FileCollector and BlockMoveTaskHandler to Context interface. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org