[ https://issues.apache.org/jira/browse/HDFS-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060938#comment-13060938 ]
Hadoop QA commented on HDFS-2132: --------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12485485/hdfs-2132.2.patch against trunk revision 1143147. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: -1 contrib tests. The patch failed contrib unit tests. -1 system test framework. The patch failed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/882//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/882//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/882//console This message is automatically generated. > Potential resource leak in EditLogFileOutputStream.close > -------------------------------------------------------- > > Key: HDFS-2132 > URL: https://issues.apache.org/jira/browse/HDFS-2132 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 0.23.0 > Reporter: Aaron T. Myers > Assignee: Aaron T. Myers > Fix For: 0.23.0 > > Attachments: hdfs-2132.0.patch, hdfs-2132.1.patch, hdfs-2132.2.patch, > hdfs-2132.3.patch > > > {{EditLogFileOutputStream.close(...)}} sequentially closes a series of > underlying resources. If any of the calls to {{close()}} throw before the > last one, the later resources will never be closed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira