[ 
https://issues.apache.org/jira/browse/HDFS-13484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448418#comment-16448418
 ] 

Íñigo Goiri commented on HDFS-13484:
------------------------------------

[~linyiqun], thanks for the comments.
[^HDFS-13484.005.patch] should cover most of them.
A couple clarifications:
* MembershipNamenodeResolver: refactored the whole method
* UI changes: the only thing to move to the other JIRA would be the HTML, JS 
and CSS files, right? If so we could do that without any unit tests. What else 
would that go there?
* TestDisableNameservices: I think this is required. First, we test the speed 
of a method that goes to all subclusters ({{renewLease()}}) and see how one is 
faster than the other. Then, we also need to check that when disabling we don't 
see the files in the other disabled subcluster.
* TestRouterAdmin: I reset the admin client it in {{Before}} to prevent 
cascading effects if the unit test fails.

> RBF: Disable Nameservices from the federation
> ---------------------------------------------
>
>                 Key: HDFS-13484
>                 URL: https://issues.apache.org/jira/browse/HDFS-13484
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Íñigo Goiri
>            Assignee: Íñigo Goiri
>            Priority: Major
>         Attachments: HDFS-13484.000.patch, HDFS-13484.001.patch, 
> HDFS-13484.002.patch, HDFS-13484.003.patch, HDFS-13484.004.patch, 
> HDFS-13484.005.patch
>
>
> HDFS-13478 introduced the Decommission store. We should disable the access to 
> decommissioned subclusters.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to