[ https://issues.apache.org/jira/browse/HDFS-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061273#comment-13061273 ]
John George commented on HDFS-2011: ----------------------------------- The patch looks good. Shouldn't the sequence "close() close()" be tested as well, since that could be a case that could possibly happen? > Removal and restoration of storage directories on checkpointing failure > doesn't work properly > --------------------------------------------------------------------------------------------- > > Key: HDFS-2011 > URL: https://issues.apache.org/jira/browse/HDFS-2011 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node > Affects Versions: 0.23.0 > Reporter: Ravi Prakash > Assignee: Ravi Prakash > Fix For: 0.23.0 > > Attachments: HDFS-2011.3.patch, HDFS-2011.4.patch, HDFS-2011.5.patch, > HDFS-2011.6.patch, HDFS-2011.7.patch, HDFS-2011.8.patch, HDFS-2011.patch, > HDFS-2011.patch, HDFS-2011.patch, elfos-close-patch-on-1073.txt > > > Removal and restoration of storage directories on checkpointing failure > doesn't work properly. Sometimes it throws a NullPointerException and > sometimes it doesn't take off a failed storage directory -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira