[ 
https://issues.apache.org/jira/browse/HDFS-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452588#comment-16452588
 ] 

Erik Krogen commented on HDFS-13286:
------------------------------------

Last comments:
* NameNode#transitionToActive and #transitionToObserver has some hard-coded 
strings, e.g. {{"Cannot transition from 'observer' to 'active'"}}, that could 
be replaced with calls to  {{OBSERVER_STATE.toString}} and 
{{ACTIVE_STATE.toString}}
* Revisiting the {{ObserverState}} at a later time sounds fine to me

Also, I managed to find the precommit build; it's timing out (I think because 
it's running the unit tests for all of hdfs, common, and yarn) but it completed 
the [common unit 
tests|https://builds.apache.org/job/PreCommit-HDFS-Build/24061/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt]
 (clean) and the [hdfs unit 
tests|https://builds.apache.org/job/PreCommit-HDFS-Build/24061/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt]
 (failures but look unrelated). Please address the outstanding 
[checkstylehttps://builds.apache.org/job/PreCommit-HDFS-Build/24061/artifact/out/diff-checkstyle-root.txt]
 issues as well.


> Add haadmin commands to transition between standby and observer
> ---------------------------------------------------------------
>
>                 Key: HDFS-13286
>                 URL: https://issues.apache.org/jira/browse/HDFS-13286
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Chao Sun
>            Assignee: Chao Sun
>            Priority: Major
>         Attachments: HDFS-13286-HDFS-12943.000.patch, 
> HDFS-13286-HDFS-12943.001.patch, HDFS-13286-HDFS-12943.002.patch
>
>
> As discussed in HDFS-12975, we should allow explicit transition between 
> standby and observer through haadmin command, such as:
> {code}
> haadmin -transitionToObserver
> {code}
> Initially we should support transition from observer to standby, and standby 
> to observer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to