[
https://issues.apache.org/jira/browse/HDFS-12002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16455130#comment-16455130
]
Hudson commented on HDFS-12002:
-------------------------------
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14070 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/14070/])
HDFS-12002. Ozone : SCM cli misc fixes/improvements. Contributed by Chen
(omalley: rev 4b63e3e504e9e226acda67f9d880ab923da2ea97)
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/scm/cli/container/ContainerCommandHandler.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/ozShell/Shell.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/scm/TestSCMCli.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/scm/cli/container/DeleteContainerHandler.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/scm/cli/container/InfoContainerHandler.java
> Ozone : SCM cli misc fixes/improvements
> ---------------------------------------
>
> Key: HDFS-12002
> URL: https://issues.apache.org/jira/browse/HDFS-12002
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Chen Liang
> Assignee: Chen Liang
> Priority: Major
> Fix For: HDFS-7240
>
> Attachments: HDFS-12002-HDFS-7240.001.patch
>
>
> Currently there are a few minor issues with the SCM CLI:
> 1. some commands do not use -c option to take container name. an issue with
> this is that arguments need to be in a certain order to be correctly parsed,
> e.g.:
> {{./bin/hdfs scm -container -del c0 -f}} works, but
> {{./bin/hdfs scm -container -del -f c0}} will not
> A more important thing is that, since -del requires the following argument
> being container name, if someone types {{./bin/hdfs scm -container -del
> -help}} it will be an error, while we probably want to display a help message
> instead.
> 2.some subcommands are not displaying the errors in the best way it could be,
> e.g.:
> {{./bin/hdfs scm -container -del}} is wrong because it misses container name.
> So cli complains
> {code}
> Missing argument for option: del
> Unrecognized options:[-container, -del]
> usage: hdfs scm <commands> [<options>]
> where <commands> can be one of the following
> -container Container related options
> {code}
> but this does not really show that it is container name it is missing
> 3. probably better to rename -del to -delete to be consistent with other
> commands like -create and -info
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
