[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461569#comment-16461569
]
Plamen Jeliazkov commented on HDFS-13399:
-----------------------------------------
Hey Konstantin,
Alright I think things are cleared up now for the most part about the overall
plan. Just a couple questions / nits:
Regarding (1), I see also you left {{DFSClient.getAlignmentContext}} in. Should
we just remove it? I don't believe there is a path from the {{ProxyProvider}}
back to the {{DFSClient}}.
Also please take a look at the comment I made here (just above):
https://issues.apache.org/jira/browse/HDFS-13399?focusedCommentId=16454623&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16454623
We can discuss this in detail next meeting but there is a serious concern
regarding the {{FSEditLogAsync}} and sending the client state over the RPC. My
suspicion is we need to make additional changes to {{FSEditLogAsync...}}
> Make Client field AlignmentContext non-static.
> ----------------------------------------------
>
> Key: HDFS-13399
> URL: https://issues.apache.org/jira/browse/HDFS-13399
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-12943
> Reporter: Plamen Jeliazkov
> Assignee: Plamen Jeliazkov
> Priority: Major
> Attachments: HDFS-13399-HDFS-12943.000.patch,
> HDFS-13399-HDFS-12943.001.patch, HDFS-13399-HDFS-12943.002.patch,
> HDFS-13399-HDFS-12943.003.patch, HDFS-13399-HDFS-12943.004.patch,
> HDFS-13399-HDFS-12943.005.patch, HDFS-13399-HDFS-12943.006.patch
>
>
> In HDFS-12977, DFSClient's constructor was altered to make use of a new
> static method in Client that allowed one to set an AlignmentContext. This
> work is to remove that static field and make each DFSClient pass it's
> AlignmentContext down to the proxy Call level.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
