[
https://issues.apache.org/jira/browse/HDDS-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465108#comment-16465108
]
Mukul Kumar Singh commented on HDDS-20:
---------------------------------------
Thanks for working on the patch [~ljain]. The patch looks really good to me.
Please find my comments as following.
1) KeyManagerImpl.java:
a) Lets add a check that if the "from" and "to" key names are same then lets
return without changing anything in database. Lets add this test after
verifying that the from key exists in the database.
b) Lets also check that the toKeyName doesn't exists before renaming the key.
c) Also lets add a check that if the fromKeyName.length is zero, then lets skip
processing of the key name.
d) 440: We should have a different error code in place of "FAILED_KEY_NOT_FOUND"
2) ClientProtocol.java:292, "renamed" in place of replaced/
3) Please also raise jira for supporting renaming for RestClient.
4) Lets also raise another jira to support rename of directory in ozonefs
atomically.
> Ozone: Add support for rename key within a bucket for rpc client
> ----------------------------------------------------------------
>
> Key: HDDS-20
> URL: https://issues.apache.org/jira/browse/HDDS-20
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Lokesh Jain
> Assignee: Lokesh Jain
> Priority: Major
> Attachments: HDDS-20.001.patch, HDFS-13228-HDFS-7240.001.patch
>
>
> This jira aims to implement rename operation on a key within a bucket for rpc
> client. OzoneFilesystem currently rewrites a key on rename. Addition of this
> operation would simplify renames in OzoneFilesystem as renames would just be
> a db update in ksm.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
