[
https://issues.apache.org/jira/browse/HDFS-13489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465468#comment-16465468
]
Mukul Kumar Singh commented on HDFS-13489:
------------------------------------------
Thanks for working on this [~hpatro]. The patch looks good to me. Some minor
comments.
1) DistributedFileSystem.java:2193, nitpick, extra line
2) ClientNamenodeProtocolTranslatorPB.java:1264, the returned string is an
optional value. Hence this can potentially return garbage, lets make the string
required in the Response object as well.
3) SnapShotManager.java:188, Please add comments around this function
4) TestGetBaseDirSnapshottable:84, since print is being used only once, lets
remove the print function and use directly.
> Get base snapshotable path if exists for a given path
> -----------------------------------------------------
>
> Key: HDFS-13489
> URL: https://issues.apache.org/jira/browse/HDFS-13489
> Project: Hadoop HDFS
> Issue Type: Task
> Components: hdfs
> Reporter: Harkrishn Patro
> Assignee: Harkrishn Patro
> Priority: Major
> Attachments: HDFS-13489.001.patch, HDFS-13489.002.patch,
> HDFS-13489.003.patch, HDFS-13489.004.patch, HDFS-13489.005.patch
>
>
> Currently, hdfs only lists the snapshotable paths in the filesystem. This
> feature would add the functionality of figuring out if a given path is
> snapshotable or not. If yes, it would return the base snapshotable path.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
