[
https://issues.apache.org/jira/browse/HDFS-13502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472729#comment-16472729
]
Hanisha Koneru commented on HDFS-13502:
---------------------------------------
Thanks for this improvement [~apoorvnaik]
Some suggestions:
# We should reuse the keys from \{{HdfsClientConfigKeys}} instead of defining
them again in {{HdfsNameServiceResolver}}. We already have all the keys defined
in that class except for \{{dfs.internal.nameservices}}. We can define this key
also in {\{HdfsClientConfigKeys}}.
# We can make the methods in {{HdfsNameServiceResolver}} as static. And avoid
initializing an instance of this class in HdfsUtils.
# Please resolve the checkstyle errors. I think most of them are for
indentation.
# Do we need to add hdfs-site.xml here? I don’t see it being used anywhere.
# Can you please rename HdfsNameServiceResolverTest to
TestHdfsNameServiceResolver to be consistent with Hdfs naming convention.
> Utility to resolve NameServiceId in federated cluster
> -----------------------------------------------------
>
> Key: HDFS-13502
> URL: https://issues.apache.org/jira/browse/HDFS-13502
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Apoorv Naik
> Assignee: Apoorv Naik
> Priority: Major
> Attachments:
> 0001-HDFS-13502-Utility-to-resolve-NameServiceId-in-feder.patch
>
>
> A Utility class in HDFS, that would act as a reverse lookup for <host>:<port>
> HDFS URLs would be beneficial for deployments having multiple namenodes and
> nameservices.
>
> Consumers would benefit by having a unified namespace across the Federated
> cluster.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
