[
https://issues.apache.org/jira/browse/HDFS-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065385#comment-13065385
]
Todd Lipcon commented on HDFS-1979:
-----------------------------------
bq. Should setStorageInfo also setBlockPoolID and setClusterID? Eg in
BN#registerWith where we call all three I'm wondering why those aren't a single
method.
Yes, I tried a couple times to do this, but it doesn't quite work because of
the inheritance structure. Since this is a carryover from the existing code,
mind if we leave as is for now?
bq. In FSIMage#getLastAppliedTxId why return editLog.getLastWrittenTxId()? It
seems like this method is for asking for the last tx from loading the
image/edits log (a static property), if someone wants the the last tx written
to the edits log (dynamic) they should use that API directly.
That seems reasonable. Let me try to fix that and upload a new patch.
bq. Why does LogLoadPlan() call super()?
Oversight. Fixed.
bq. BackupNodeProtocol isAlive and startLogSegment need javadocs
It turns out isAlive wasn't being called, so I removed it for now. Fixed
javadoc for startLogSegment
bq. FSNamesystem#registerBackupNode params could use a comment/better names to
distinguish which registration is which (eg bnReg, nnReg)
Fixed
bq. BN "Is journal spooling in progress" comment should be replaced with a new
description
fixed
> HDFS-1073: Fix backupnode for new edits/image layout
> ----------------------------------------------------
>
> Key: HDFS-1979
> URL: https://issues.apache.org/jira/browse/HDFS-1979
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hdfs-1979-prelim.txt, hdfs-1979.txt, hdfs-1979.txt
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
