[ https://issues.apache.org/jira/browse/HDDS-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16481738#comment-16481738 ]
Anu Engineer commented on HDDS-88: ---------------------------------- [~nandakumar131] Thanks for taking care of this, if you write a wrapper for setRatis port and SetContainerPort and SetRestPort -- For the time being the code changes will be less. But frankly, I don't have an opinion on it. So feel free not do it since you have made all the needed modifications :( I like the Enum idea, so the String portName is an Enum in HDDS.proto. I am overall +1 on this change. > Create separate message structure to represent ports in DatanodeDetails > ------------------------------------------------------------------------ > > Key: HDDS-88 > URL: https://issues.apache.org/jira/browse/HDDS-88 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: Ozone Datanode, SCM > Affects Versions: 0.2.1 > Reporter: Nanda kumar > Assignee: Nanda kumar > Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-88.000.patch > > > DataNode uses many ports which have to be set in DatanodeDetails and sent to > SCM. This port details can be extracted into a separate protobuf message. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org