[
https://issues.apache.org/jira/browse/HDDS-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489547#comment-16489547
]
Xiaoyu Yao commented on HDDS-72:
--------------------------------
Thanks [~ljain] for working on this. The patch looks good to me overall. I just
have a few questions.
>From the description, I'm not fully convinced that we should track the deleted
>blocks/container. This may increase the size of the container metadata db and
>affect the normal key operations.
This might be needed when we bring in full version support. Otherwise, we could
live with just tracking the pending deletion blocks like HDFS does.
MetadataKeyFilters.java
Line 32: this introduced a new key prefix, should we update the normalKeyFilter
as well so that we don't see deleted key in a normal key query.
> Add numDeletedBlocks field in ContainerInfo
> -------------------------------------------
>
> Key: HDDS-72
> URL: https://issues.apache.org/jira/browse/HDDS-72
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Datanode, SCM
> Affects Versions: 0.2.1
> Reporter: Lokesh Jain
> Assignee: Lokesh Jain
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-72.001.patch, HDDS-72.002.patch, HDDS-72.003.patch
>
>
> This Jira aims to add numDeletedBlocks field in SCMContainerInfo and
> ContainerInfo in hdds.proto and StorageContainerDatanodeProtocol.proto
> respectively. This field would serve as a generation Id for block deletes as
> it is monotonically increasing in nature and would also give information
> about the number of deleted blocks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
