[ 
https://issues.apache.org/jira/browse/HDFS-13653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503545#comment-16503545
 ] 

Íñigo Goiri commented on HDFS-13653:
------------------------------------

bq. Each of the mock is a closure on an unique atomicInteger corresponding to 
the mock.

You can use a map of AtomicIntegers and then as the key you can get the target 
ns from the InvocationOnMock.
You probably could also leverage the proxyMap you have there.

Another couple minor nits:
* Use setBoolean instead of set "true".
* Make the numIterations a class constant.
* The test could use a few comment for the high levle idea of each of the tests 
and the requirements for createFactory.

> Make dfs.client.failover.random.order a per nameservice configuration
> ---------------------------------------------------------------------
>
>                 Key: HDFS-13653
>                 URL: https://issues.apache.org/jira/browse/HDFS-13653
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: federation
>            Reporter: Ekanth Sethuramalingam
>            Assignee: Ekanth Sethuramalingam
>            Priority: Major
>         Attachments: HDFS-13653.001.patch, HDFS-13653.002.patch, 
> HDFS-13653.003.patch, HDFS-13653.004.patch, HDFS-13653.005.patch, 
> HDFS-13653.006.patch, HDFS-13653.007.patch
>
>
> Currently the dfs.client.failover.random.order is applied globally. If we 
> have a combination of router and non-router nameservice, the random order 
> should ideally be enabled only for the router based nameservice. This Jira is 
> to make this configuration per-nameservice so that this can be configured 
> independently for each nameservice. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to